fix(rivetkit): warn when manager port falls back to a different port#4489
Conversation
|
🚅 Deployed to the rivet-pr-4489 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: fix(rivetkit): warn when manager port falls back to a different portThis is a small, focused change that adds a warning log when findFreePort returns a different port than the configured one. The intent is correct and addresses a real UX gap - port fallback previously happened silently. FeedbackStructured logging The warning interpolates port numbers directly into the msg string. Per the project structured logging convention in CLAUDE.md, parameters should not be formatted into the main message - they should be separate fields. This is also consistent with the adjacent logger().debug() call below it, which already uses named fields (port: managerPort). Current code uses: msg interpolated with configuredManagerPort and managerPort. Suggested approach: use msg set to "manager port is in use, falling back to a different port" with configuredPort and actualPort as separate named fields. This makes the port values queryable and filterable in log aggregation tools. SummaryThe change is correct and well-placed. The only suggested improvement is separating the port values into named structured fields rather than interpolating them into the message string. |
93952ec to
f3e0879
Compare
9782f44 to
1bcf7a1
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: